Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ci #22

Merged
merged 6 commits into from
Jul 9, 2024
Merged

update ci #22

merged 6 commits into from
Jul 9, 2024

Conversation

mehdi-torabiv
Copy link
Collaborator

@mehdi-torabiv mehdi-torabiv commented Jul 9, 2024

Summary by CodeRabbit

  • Chores

    • Renamed CI workflow from on-chain-platform-build to on-chain-platform-ci.
    • Updated Code Climate action configuration.
    • Added coverage directory to .gitignore.
    • Added script for running coverage tests in package.json.
  • New Features

    • Configured code coverage using Istanbul in Vite.
    • Set server port to 3000 and added module resolution alias in Vite configuration.

Copy link

coderabbitai bot commented Jul 9, 2024

Warning

Rate limit exceeded

@mehdi-torabiv has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 53 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between ded7867 and 901d39f.

Walkthrough

The recent updates streamline the development workflow for the on-chain platform. The GitHub Actions workflow was renamed and enhanced with Code Climate configuration, and code coverage tracking was added through Vite integration and a new script in package.json. Additionally, the Vite configuration was improved for better module resolution and server handling. Finally, coverage was added to the .gitignore file to keep the repository clean from test coverage artifacts.

Changes

Files/Paths Change Summaries
.github/workflows/ci.yml Renamed workflow to on-chain-platform-ci and adjusted Code Climate action configuration.
.gitignore Added coverage to ignore list.
package.json Added "coverage": "vitest run --coverage" script and updated devDependencies for testing libraries.
vite.config.ts Added Istanbul for code coverage, configured server port, and added module resolution alias.

Poem

From CodeRabbit, with delight,
Our build evolved in the night.
With coverage grand,
And configs at hand,
Our platform now shines ever so bright! 🌟🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2c0b90e and ee0bb61.

Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/ci.yml

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ee0bb61 and 0cd8863.

Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing (2)
  • package.json (2 hunks)
  • vite.config.ts (1 hunks)
Additional comments not posted (3)
vite.config.ts (1)

14-16: LGTM! Added coverage configuration using Istanbul.

The added configuration for test coverage using Istanbul is correct.

package.json (2)

14-14: LGTM! Added coverage script.

The added script for running coverage tests is correct.


36-39: LGTM! Updated devDependencies.

The updates to the @testing-library/dom and @testing-library/user-event devDependencies are correct.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0cd8863 and ded7867.

Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing (3)
  • .gitignore (1 hunks)
  • package.json (3 hunks)
  • vite.config.ts (2 hunks)
Files skipped from review due to trivial changes (1)
  • .gitignore
Files skipped from review as they are similar to previous changes (1)
  • package.json
Additional context used
GitHub Check: test/node 17/ubuntu-latest
vite.config.ts

[failure] 4-4:
Cannot find module 'path' or its corresponding type declarations.


[failure] 23-23:
Cannot find name '__dirname'.

GitHub Check: test/node 18/ubuntu-latest
vite.config.ts

[failure] 4-4:
Cannot find module 'path' or its corresponding type declarations.


[failure] 23-23:
Cannot find name '__dirname'.

Additional comments not posted (4)
vite.config.ts (4)

4-4: Ensure type declarations for the path module are available.

The static analysis hints indicate that TypeScript cannot find the module path or its corresponding type declarations. Ensure that @types/node is installed as a dev dependency to provide type declarations for Node.js core modules.

npm install --save-dev @types/node
Tools
GitHub Check: test/node 17/ubuntu-latest

[failure] 4-4:
Cannot find module 'path' or its corresponding type declarations.

GitHub Check: test/node 18/ubuntu-latest

[failure] 4-4:
Cannot find module 'path' or its corresponding type declarations.


15-17: LGTM!

The coverage configuration using Istanbul as the provider looks good.


19-21: LGTM!

The server configuration to run on port 3000 looks good.


22-24: Ensure __dirname is recognized in the current context.

The static analysis hints indicate that __dirname might not be recognized. Ensure that you are running the configuration in a Node.js environment where __dirname is available. If using ES modules, you might need to use import.meta.url or configure it appropriately.

import { fileURLToPath } from 'url';
import { dirname } from 'path';

const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);
Tools
GitHub Check: test/node 17/ubuntu-latest

[failure] 23-23:
Cannot find name '__dirname'.

GitHub Check: test/node 18/ubuntu-latest

[failure] 23-23:
Cannot find name '__dirname'.

@mehdi-torabiv mehdi-torabiv merged commit 385fbaf into main Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant